Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No grid auto-refresh for backfill dag runs #25042

Merged
merged 7 commits into from
Jul 20, 2022

Conversation

yingxuanwangxuan
Copy link
Contributor

@yingxuanwangxuan yingxuanwangxuan commented Jul 14, 2022

Don't run auto-refresh for backfill dag runs.
Closes: #24844


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 14, 2022
@yingxuanwangxuan
Copy link
Contributor Author

what is this error,can you help me, thanks.
image

@josh-fell
Copy link
Contributor

HI @yingxuanwangxuan, can you an explanation in the PR description of what's being fixed and how this PR resolves the issue. It's not entirely clear without a description or a linked issue.

@bbovenzi
Copy link
Contributor

Issue: #24844

Not sure about the CI failure. I'd say rebase the branch and see if it persists.

@eladkal eladkal added this to the Airflow 2.3.4 milestone Jul 19, 2022
@bbovenzi bbovenzi changed the title Fix grid data auto refresh No grid auto-refresh for backfill dag runs Jul 20, 2022
@bbovenzi bbovenzi merged commit de6938e into apache:main Jul 20, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 20, 2022

Awesome work, congrats on your first merged pull request!

@yingxuanwangxuan yingxuanwangxuan deleted the fix_grid_data_auto_refresh branch July 20, 2022 11:25
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Aug 14, 2022
ephraimbuddy pushed a commit that referenced this pull request Aug 15, 2022
* Update useGridData.ts

* Update useGridData.test.js

* Update useGridData.test.js

(cherry picked from commit de6938e)
@@ -49,7 +49,7 @@ const emptyGridData: GridData = {
},
};

export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['manual', 'manual'].includes(run.runType)).filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely this should be:

export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['scheduled', 'manual'].includes(run.runType)).filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fix this. @bbovenzi can you review it again?

cloventt added a commit to cloventt/airflow that referenced this pull request Aug 25, 2022
In PR apache#25042 the merged change included a bug that prevents the page
from auto-refreshing if there are anything other than manual runs on the
page. We also want to auto-refresh for scheduled runs.

I've also added more complete unit tests for the expected behaviour.
potiuk pushed a commit that referenced this pull request Aug 25, 2022
In PR #25042 the merged change included a bug that prevents the page
from auto-refreshing if there are anything other than manual runs on the
page. We also want to auto-refresh for scheduled runs.

I've also added more complete unit tests for the expected behaviour.
ephraimbuddy pushed a commit to astronomer/airflow that referenced this pull request Aug 25, 2022
In PR apache#25042 the merged change included a bug that prevents the page
from auto-refreshing if there are anything other than manual runs on the
page. We also want to auto-refresh for scheduled runs.

I've also added more complete unit tests for the expected behaviour.

(cherry picked from commit 37ec752)
Gollum999 added a commit to Gollum999/airflow that referenced this pull request Sep 18, 2022
bbovenzi pushed a commit that referenced this pull request Sep 21, 2022
* Revert "No grid auto-refresh for backfill dag runs (#25042)"

This reverts commit de6938e.

* Fix Grid unit test
ephraimbuddy pushed a commit that referenced this pull request Oct 18, 2022
* Revert "No grid auto-refresh for backfill dag runs (#25042)"

This reverts commit de6938e.

* Fix Grid unit test

(cherry picked from commit d0b3d59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid_data api keep refreshing when backfill DAG runs
6 participants